Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install vue3-openlayers 6.0.1 due to dependencies errors #308

Closed
lmc3s3f0r opened this issue Mar 7, 2024 · 3 comments
Closed

Can't install vue3-openlayers 6.0.1 due to dependencies errors #308

lmc3s3f0r opened this issue Mar 7, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@lmc3s3f0r
Copy link

Describe the bug
Tried to upgrade to vue3-openlayers 6.0.1, so I added these dependencies to my project's package.json:

"ol-contextmenu": "^5.3.0",
"ol-ext": "^4.0.15",
"ol": "^9.0.0",
"vue": "3.4.21",
"vue3-openlayers": "^6.0.1"

And when I run npm install, I instantly get these error messages:

npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/ol
npm ERR!   ol@"^9.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer ol@"> 7.x <= 8.x" from [email protected]
npm ERR! node_modules/ol-contextmenu
npm ERR!   ol-contextmenu@"^5.3.0" from the root project

Which I can confirm in ol-contextmenu's package.json: https://github.com/jonataswalker/ol-contextmenu/blob/master/package.json

 "peerDependencies": {
        "ol": "> 7.x <= 8.x"
    },

Affected version(s)
6.0.1

To Reproduce
Steps to reproduce the behavior:

  1. Add this to your project's package.json:
"ol-contextmenu": "^5.3.0",
"ol-ext": "^4.0.15",
"ol": "^9.0.0",
"vue": "3.4.21",
"vue3-openlayers": "^6.0.1"
  1. Delete node_modules and package-lock.json
  2. Run npm intall
  3. See error

Expected behavior
I'd expect being able to install without issues.

Desktop (please complete the following information):

  • OS: Ubuntu 22
  • Browser: not relevant (it's in VSCode)
@lmc3s3f0r lmc3s3f0r added the bug Something isn't working label Mar 7, 2024
@d-koppenhagen
Copy link
Collaborator

Hey, please check out the issue here with the workaround for your package.json:

"overrides": {
    "ol-contextmenu": {
      "ol": "^9.x"
    }
  }

ol-contextmenu will be updated hopefully soon. The override should be fine for now, since there is no breaking change from OpenLayers 9 which breaks ol-contextmenu.

@d-koppenhagen
Copy link
Collaborator

I created a PR: jonataswalker/ol-contextmenu#278

@d-koppenhagen
Copy link
Collaborator

fixed with version 6.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants