[🐞]: Lumisene can fail to reach equillibrium in spaces where it can be evenly distributed

[VoidLeech]

Before Continuing:

• Check you are using the latest version of the mods and its dependencies
• Always include a latest.log if you are crashing
• Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue persists.
• If you are unsure which mod is the culprit.
  Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
• Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version

1.20.1-FORGE

Supplementaries Version

supplementaries-1.20-3.1.10

Moonlight Lib Version

moonlight-1.20-2.13.41

Describe Issue

This isn't very consistent, but when placing lumisene in confined spaces, there's just a chance it will fail to reach equillibrium, even though all the layers could be evenly spread. I can't give better reproduction steps than just placing a bucket in a 2x2 until it does.
I don't think the logs have anything interesting (related to this issue, there do appear to be some related to supplementaries) but just in case.
Latest: https://mclo.gs/jGb5qjh
Debug: https://mclo.gs/kZTe0hq

2024-12-23.13-51-54.mp4

[MehVahdJukaar]

the way the fluid works is in a non deterministic manner. it checks 1 direction at random in which it can spread and tries to add 1 layer there. this obviously becomes an iterative process. this means that some considred stable configuration might never reach equilibrium as its left to chance.
unfortunately i dont know good solutions to this issue

[MehVahdJukaar]

i believe i might add a small chance that it decides not to try to spreaed that tick. this would intern create case where the fluid seems slower to spread but could avoid some of those cyclical issues that could appear often insuch a small configuration like a 2x2. infact i think this is quite specific to that 2x2