New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sinkhorn distance implementation #19

Open

utkutpcgl opened this issue Jun 8, 2023 · 1 comment

utkutpcgl commented Jun 8, 2023

Thanks for the great contribution!

As mentioned in #17 (comment), the original sinkhorn implementation is different (page 11 of your paper):

Why is this the case?

Author

utkutpcgl commented Jun 14, 2023 •

edited

Loading

By the way here is the original implementation u is updated first. u and v updates seem to be switched (confused?) in this paper:

https://github.com/gpeyre/SinkhornAutoDiff/blob/1e6c8c38974a325bb59cbc5b8cb6af5787b4f58d/sinkhorn_pointcloud.py#L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment