Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevOps: Removes unnecessary dotnet setup #5873

Merged
merged 2 commits into from
Dec 17, 2024
Merged

DevOps: Removes unnecessary dotnet setup #5873

merged 2 commits into from
Dec 17, 2024

Conversation

tesar-tech
Copy link
Collaborator

Description

Just a quick fix from seeing warnings in gha log.

dotnet is there on ubuntu by default

@tesar-tech tesar-tech requested a review from stsrki November 30, 2024 21:29
stsrki
stsrki reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@stsrki stsrki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we are safe to remove older frameworks. We need to keep them to make sure that the build is passing on all of them.

@tesar-tech
Copy link
Collaborator Author

No, no.. It doesn't remove them, because they are part of the ubuntu-latest. This PR just removes the the unnecessary setup, that does nothing actually.

image

@stsrki stsrki merged commit f98c063 into master Dec 17, 2024
2 checks passed
@stsrki stsrki deleted the dev/github-action-update branch December 17, 2024 08:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stsrki stsrki stsrki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesar-tech @stsrki