Snackbar: fixed position on mobile #5003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steal4life |
|
Yes it is @David-Moreira |
David-Moreira
approved these changes
Oct 7, 2023
|
@David-Moreira this solution works, but in case the snackbar is 50 percent of the screen height, then for some reason it will go down again, as long as it's smaller it should work |
David-Moreira
requested changes
Oct 9, 2023
stsrki
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4994
Reason behind:
In the previous version the snackbar stack didn't have keyframes in its scss that now allow opening and closing animations... among other things they caused only half of the snackbar to be visible on mobile, so I made a few changes with the animations to avoid that behavior