Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete validation refactor #4767

Open
David-Moreira opened this issue May 12, 2023 · 7 comments
Open

Autocomplete validation refactor #4767

David-Moreira opened this issue May 12, 2023 · 7 comments
Assignees
Milestone

Comments

@David-Moreira
Copy link
Contributor

          I was just taking a brief look at `Autocomplete` validation, correct me if I'm wrong @stsrki 

but from what I can tell, in Autocomplete you either have to set the Validator or AsyncValidator parameters with your validation.
image
image
https://blazorise.com/docs/extensions/autocomplete

I believe Data Annotations aren't currently supported by Autocomplete in that case. Again correct me If I'm wrong.

Also I'd argue that we should remove the internal Validator and Validator / AsyncValidator and just have the validation work as regular Blazorise Validation would work, by wrapping with the Validations / Validator outside the Autocomplete.

Originally posted by @David-Moreira in #4628 (comment)

@David-Moreira David-Moreira added this to the 2.0 milestone May 12, 2023
@David-Moreira
Copy link
Contributor Author

@stsrki Let's consider if this is a worthy refactor

@PatrickBig
Copy link

I just ran into a need for this as well. It would be a worthy addition

@stsrki stsrki modified the milestones: 1.4, 2.0 Nov 29, 2023
@WayneHiller
Copy link
Contributor

Autocomplete having it's own Validation is causing me a lot of problems because I use Fluent Validation everywhere else in my app.

@spingee
Copy link
Contributor

spingee commented Jun 12, 2024

Its not possible to use dataannotation/fluent validations at all when heavily used autocomplete does not support it...

@stsrki
Copy link
Collaborator

stsrki commented Jun 13, 2024

Hello. We are aware of the limitations with validation on Autocomplete. But due to the needed changes we are planning to do it in 2.0 release.

@stsrki stsrki moved this to 🔙 Triage in Development Jul 26, 2024
@stsrki stsrki removed this from Development Jul 26, 2024
@Hyppothalamus
Copy link

Are their any updates on this topic?

@stsrki
Copy link
Collaborator

stsrki commented Dec 20, 2024

It is planned for 2.0. We haven't started working on this feature yet because we had first to refactor input APIs, see #5732

Now that that is mostly done, we can start working on Autocomplete. But it is not going to be released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants