Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose errMsgId to subscribers #57

Open
joshfriend opened this issue Jun 15, 2017 · 2 comments
Open

Expose errMsgId to subscribers #57

joshfriend opened this issue Jun 15, 2017 · 2 comments

Comments

@joshfriend
Copy link

If the fingerprint authentication fails with an error like FINGERPRINT_ERROR_LOCKOUT, the UI should display an error for a longer period of time than if the error is FINGERPRINT_ACQUIRED_TOO_FAST for example. There is currently no way to know what the specific error condition of the reader is. The error id should be passed along inside FingerprintAuthenticationException

@Mauin
Copy link
Owner

Mauin commented Jun 15, 2017

I can think about passing the ID of the error message along.

Generally all errors that cause the Fingerprint sensor to "lock down" (FINGERPRINT_ERROR_LOCKOUT is one example of this) will be passed in .onError(). Recoverable Errors such as moving the finger too fast will be delivered in .onNext(). This distinction between .onNext and .onError already gives a hint at the severity of the issue.

@joshfriend
Copy link
Author

Thanks for pointing that out! It does help a lot, but if the subscriber is disposed on rotation, cancellationSignal.cancel() causes FINGERPRINT_ERROR_CANCELED to be sent to the onAuthenticationError callback. It would be nice to be able to distinguish this from an error condition that should be shown to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants