You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we're relying on a third-party package, jcommander, for command-line argument parsing. There are both advantages and disadvantages when it comes to removing this package:
Advantages:
- More control over implementation and API of the CLI
- Less coupled to third-party dependencies
- No dependency maintenance (since it's the only third-party package on which we rely, other than junit of course)
Disadvantages:
- We would be slightly re-inventing the wheel. However, the TypeScript compiler has its own home-grown command line parser and executor, so why can't Torrey have one as well?
- More development effort.
- Could lead to an introduction to more bugs. However, we have junit to write tests for it.
Acceptance Criteria:
- Implement a new command-line parser that does not change how the compiler is currently used. That is, all existing command line arguments (e.g., --help, -h, --target, etc.) should still work after the new parser is implemented.
- Since we'll be writing our own parser, the internal API used to parse CLI args will change and probably deviate from that used by jcommander. This is expected and is totally fine.
The text was updated successfully, but these errors were encountered:
Currently, we're relying on a third-party package,
jcommander
, for command-line argument parsing. There are both advantages and disadvantages when it comes to removing this package:Advantages:
- More control over implementation and API of the CLI
- Less coupled to third-party dependencies
- No dependency maintenance (since it's the only third-party package on which we rely, other than
junit
of course)Disadvantages:
- We would be slightly re-inventing the wheel. However, the TypeScript compiler has its own home-grown command line parser and executor, so why can't Torrey have one as well?
- More development effort.
- Could lead to an introduction to more bugs. However, we have
junit
to write tests for it.Acceptance Criteria:
- Implement a new command-line parser that does not change how the compiler is currently used. That is, all existing command line arguments (e.g.,
--help
,-h
,--target
, etc.) should still work after the new parser is implemented.- Since we'll be writing our own parser, the internal API used to parse CLI args will change and probably deviate from that used by
jcommander
. This is expected and is totally fine.The text was updated successfully, but these errors were encountered: