Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task 1] Project setup, About block #12

Open
8 tasks
vladyslav-yermolin-moc opened this issue Apr 14, 2024 · 0 comments
Open
8 tasks

[Task 1] Project setup, About block #12

vladyslav-yermolin-moc opened this issue Apr 14, 2024 · 0 comments

Comments

@vladyslav-yermolin-moc
Copy link
Collaborator

vladyslav-yermolin-moc commented Apr 14, 2024

1. Setup remote and local repositories

1.1. Fork main repository.
image

1.2. Clone your remote repo to your local machine

git clone [email protected]:vladyslav-yermolin-moc/fe-react-2024.git

1.3. Add MA remote repository as the second remote (in the future you will get some important updates form it)

git remote add moc [email protected]:MastersAcademy/fe-react-2024.git
# check if it was added
git remote -v
moc     [email protected]:MastersAcademy/fe-react-2024.git (fetch)
moc     [email protected]:MastersAcademy/fe-react-2024.git (push)
origin  [email protected]:vladyslav-yermolin-moc/fe-react-2024.git (fetch)
origin  [email protected]:vladyslav-yermolin-moc/fe-react-2024.git (push)

1.4. Install dependencies

npm ci

1.4.1. Optional - set up linters (EsLint, StyleLint, Prettier) for fixing errors on save.

2. Do the code (an easy part 🙄)

2.1. Run the local dev server

npm run dev

2.2. Add block About and image from the design. You can pick those layout, which you like. Start from the mobile version (mobile first😎).
image

2.3. Checkout to new branch

git checkout -b task/01-setup

2.4. Add your changes to commit, commit them, and push to your remote repo (good luck with linters 🤞😑)

3. Setup deployment on your remote repo

3.1. Enable actions in your repo
image

3.2. Setup deployment from action
image

3.3. Add pattern task/** to git-hub-pages env, to enable deploy from these branches
image
image

  1. Set up the rules for your main branch:
  • Require a pull request before merging
  • Require approvals - 1 approve
  • Require conversation resolution before merging
    image
    image
  1. If Octocat is on your side, you will see the link to your deployed app in settings and in pull request.
    image
    image

  2. Add your mentors (main and support) from the table(--> ADD TABLE LINK <--) to your repo as collaborators
    image

  3. Create a pull-request, add your main mentor to it like a Reviewer and copy AC 👇👇👇

Acceptance criteria for 1

  • Mentor is added to pr
  • AC copied to pr description
  • link to deployed version added to pr
  • About block (text and image) added to the main page
  • On the widths 390px and 1280px, the site layout corresponds to the design

Acceptance criteria for 1*

  • Created separate component About
  • Its styles added to .module.css
  • For App.tsx styles moved to App.module.css
Example of pr https://github.com/vladyslav-yermolin-moc/pull/1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant