Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default userDisplayName to empty string when not specified #536

Closed
MasterKale opened this issue Mar 1, 2024 · 1 comment · Fixed by #538
Closed

Default userDisplayName to empty string when not specified #536

MasterKale opened this issue Mar 1, 2024 · 1 comment · Fixed by #538
Milestone

Comments

@MasterKale
Copy link
Owner

MasterKale commented Mar 1, 2024

Describe the issue

The definition of PublicKeyCredentialUserEntity.displayName was refined in L3 to declare that it is preferable to set this value to an empty string when it's not needed:

A human-palatable name for the user account, intended only for display. The Relying Party SHOULD let the user choose this, and SHOULD NOT restrict the choice more than necessary. If no suitable or human-palatable name is available, the Relying Party SHOULD set this value to an empty string.

(Emphasis mine)

I should update generateRegistrationOptions() accordingly to match this behavior. Right now it defaults to the same value as userName when not specified.

@MasterKale
Copy link
Owner Author

This change is now available in the recently-published @simplewebauthn/[email protected] ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant