Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eu.gcr.io to cr_buildstep_docker/cr_deploy_docker/cr_deploy_run #93

Open
pauljeroenr opened this issue Nov 18, 2020 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@pauljeroenr
Copy link

Is it possible to add a parameter to host the docker images on the EU servers for container registry (eu.gcr.io)?

@MarkEdmondson1234
Copy link
Owner

I'll need some code example to be sure what you are asking, but when building your docker containers you can choose any location including eu.gcr.io.

The cr_deploy_* functions are calling building blocks below so you can further customise there - if you have an example you need to use the custom functions but would prefer in the cr_deploy_* functions let me know.

@MarkEdmondson1234
Copy link
Owner

Perhaps this line could be changed? It would only use gcr.io at the moment:

prefix <- grepl("^gcr.io", image)
if(prefix){
the_image <- image
} else {
the_image <- paste0("gcr.io/", projectId, "/", image)
}

@pauljeroenr
Copy link
Author

Ah yes. I changed that part to eu.gcr.io and now its working for me. Thank you for the easy fix.
Would it be possible in later release to have a parameter in the cr_deploy_docker() wrapper to easily use eu.gcr.io as host for the container registry?

@MarkEdmondson1234 MarkEdmondson1234 added the enhancement New feature or request label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants