Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude manual control and land preparation from MarkSuccess() #252

Open
tsaoyu opened this issue Jun 8, 2018 · 3 comments
Open

Exclude manual control and land preparation from MarkSuccess() #252

tsaoyu opened this issue Jun 8, 2018 · 3 comments
Assignees
Milestone

Comments

@tsaoyu
Copy link
Member

tsaoyu commented Jun 8, 2018

In our first 17:58:40 07June 2018 and second run 18:34:40 07June 2018 the boat keeps jibe because most attempts on tack failed when it was not in autonomous mode. I assume jibe is always picked due to all tack fails when we either in manual control or doing preparation on the land.

The issue can be partially addressed by relaunch in the middle of the ocean.

It would be nice to exclude those attempts by reading the state from /remote_control

@Nanoseb
Copy link
Member

Nanoseb commented Jun 8, 2018

Oh yes, I didn't think about that, that's indeed needed

@Nanoseb Nanoseb added this to the WRSC 2018 milestone Jun 8, 2018
@Nanoseb Nanoseb self-assigned this Jun 8, 2018
@Nanoseb
Copy link
Member

Nanoseb commented Jun 8, 2018

Do you think resetting the history when ever we switch from remote control to autonomous is a good idea?

@tsaoyu
Copy link
Member Author

tsaoyu commented Jun 8, 2018

I would suggest down/up/down1 combination in 1 second as a signal to reset the history. The advantage is that a short take over wouldn't completely wipe out the history.

1 up: AUTO or 0 down: MANUAL or 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants