Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searing Spotlights Environment Does Not Work On macOS #10

Open
WilliamYue37 opened this issue Nov 8, 2023 · 5 comments
Open

Searing Spotlights Environment Does Not Work On macOS #10

WilliamYue37 opened this issue Nov 8, 2023 · 5 comments

Comments

@WilliamYue37
Copy link

Problem Description

The lights never seem to dim for the Searing Spotlights environment, causing the spotlights to be unnoticeable. Messing around with the "Light Parameters" such as "light_dim_off_duration" and "light_threshold" seem to have no effect.

Video Clip

Here is a link to a video clip showing a random policy running in the Searing Spotlights environment. The environment in the video was rendered with "rgb_array" as the render mode. The "debug_rgb_array" render mode outputs the same thing.
Google Drive Link (takes a while to load)

To Reproduce

Running on an M2 Macbook Air with macOS Sonoma 14.0.
Commands to run:

conda create -n memory-gym python=3.11 --yes
conda activate memory-gym
git clone https://github.com/MarcoMeter/drl-memory-gym.git
cd drl-memory-gym
pip install -e .
python memory_gym/searing_spotlights.py

The repository was cloned with commit 7900c0d046680fbaee1712c98daa88a2ad3be3f8.
I have also verified that I am running with PyGame 2.4.0 and Gymnasium 0.29.0.

>>> import pygame
pygame 2.4.0 (SDL 2.26.4, Python 3.11.5)
Hello from the pygame community. https://www.pygame.org/contribute.html
>>> pygame.version.ver
'2.4.0'
>>> import gymnasium
>>> gymnasium.__version__
'0.29.0'
@MarcoMeter
Copy link
Owner

Hi @WilliamYue37

thanks for bringing this to our attention.

Unfortunately, I don't have a Mac system available. So I was not able to reproduce your issue by following your steps.
At least I can verify that this issue is not apparent when running on Colab.

I will try to get a hold of a Mac to reproduce your issue.
In the meantime, could you try pygame 2.5.2 and 2.1.3?
I suspect that this might be a pygame issue.

@WilliamYue37
Copy link
Author

@MarcoMeter Appreciate the prompt response and quick turnaround!

I tried running Searing Spotlights on a machine operating Ubuntu 20.04.1, and it worked without any issues. It appears that the problem is specific to macOS (I've updated the title to reflect this). I attempted to run Searing Spotlights on macOS with both pygame 2.5.2 and 2.1.3, but neither resolved the issue—the lights still do not dim. Fortunately, this is not a critical or blocking problem for me, as I can continue working on the Ubuntu machine. Thanks again for your help.

@WilliamYue37 WilliamYue37 changed the title Searing Spotlights Environment Does Not Work Searing Spotlights Environment Does Not Work On macOS Nov 10, 2023
@MarcoMeter
Copy link
Owner

I'm still waiting for access to a mac.

Can you try using pygame-ce (based on this conversation)?

pip uninstall pygame
pip install pygame-ce --upgrade

@WilliamYue37
Copy link
Author

Swapping out pygame for pygame-ce did not seem to do anything. I verified that I was running pygame-ce

>>> import pygame
pygame-ce 2.3.2 (SDL 2.26.5, Python 3.11.5)
>>> pygame.version.ver
'2.3.2'

@MarcoMeter
Copy link
Owner

I was able to reproduce this issue on a macbook as well. I will try to find a fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants