[BUG] Adding additional damage with AE does not include damage types

[maxobremer]

Description
When you use an active effect to add extra damage, for example for the divine favor spell, the extra damage is added, but loses its damage type.
For divine favor i made an active effect with system.bonuses.mwak.damage ADD +1d4[radiant]

Without any modules it rolled the damage of the attack with the radiant damage separate.

With RSR active the roll used the [radiant] as flavour in the roll but just piled it on the slashing damage.

Steps to Reproduce

1. Have only RSR as your active modules
2. give an actor an affect that grants them additional damage set up like: system.bonuses.mwak.damage ADD +1d4[radiant]
3. have quick roll for items enabled in the RSR settings for items*
4. Roll for damage with a melee weapon or whatever you have given extra damage
5. See that the radiant damage is added as flavour but not as actual radiant damage

*I tested this with only quick roll enabled and with every setting enabled separately. Issue persists as long as you have quick roll enabled even when you use alt to override it. No quickroll enabled=no issue

Versions

• Module: [3.2.0]
• dnd5e: [3.3.1]
• Foundry: [12.331]

Other Modules
No other modules

[MathewBissonnette]

It appears the problem is in hooks.js. On line 60, changing CONFIG.DND5E.aggregateDamageDisplay = false; to instead =true fixes the problem.

[MangoFVTT]

This is an issue that needs to be fixed by a change in the system. The CONFIG.DND5E.aggregateDamageDisplay being false is correct, as this will stop damage fields of the same type from being combined into one field automatically (a big point of contention that people wanted). Unfortunately, it also means certain parsing of contextual damage (the [ ] stuff) is skipped as well. I'll need to make a PR for the system at some point that fixes it so the parsing is always done regardless of whether or not the damage is being aggregated