Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instance types to be pulled from github.com #760

Open
Fryguy opened this issue Apr 27, 2022 · 2 comments
Open

Allow instance types to be pulled from github.com #760

Fryguy opened this issue Apr 27, 2022 · 2 comments

Comments

@Fryguy
Copy link
Member

Fryguy commented Apr 27, 2022

I was thinking about how instance types are not updated until the next refresh and once we've merged #752, I wonder if those values can be pulled live from this repo during refresh, or perhaps on demand. I haven't worked out all of the details in my head, but some points I'm thinking:

  1. We would need to include a version number or flag or something in the yaml file and/or permanently ensure backward compatibility.
  2. Since it's unlikely to update that frequently we might want to use an ETag to avoid pulling something that hasn't changed.
  3. Failure to fetch, update, anything would gracefully write a log message and move on.
  4. Users should be able to "opt-out" or "opt-in" in case they are deploying into a DMZ and don't want to be pulling from github.com
@Fryguy
Copy link
Member Author

Fryguy commented Apr 27, 2022

some info on the etag:

$ curl -i https://raw.githubusercontent.com/ManageIQ/manageiq-providers-amazon/master/db/fixtures/aws_instance_types.yml
HTTP/2 200
...
etag: "f45f89c670445b64ace7a519c008c904c7d267def483f665487b0f60b1719734"
...

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants