Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perceptually uniform ggplot colormaps #19

Open
asinghvi17 opened this issue Feb 9, 2023 · 5 comments
Open

Perceptually uniform ggplot colormaps #19

asinghvi17 opened this issue Feb 9, 2023 · 5 comments

Comments

@asinghvi17
Copy link
Member

Would be nice to maybe depend on PerceptualColourMaps.jl for this. The current colormaps are just formed by two colors, which I would like to move past in the long term.

@mkborregaard
Copy link
Collaborator

No reason to depend on that package. Every plot package should depend on Colorschemes (and Makie already does this), which also includs all the PerceptualColorMaps under the name "colorcet".

@asinghvi17
Copy link
Member Author

Right, but unless I'm missing something, the colormaps here are not included in colorcet, so we'd have to generate them. They look fine now, this is more of a nice-to-have.

@mkborregaard
Copy link
Collaborator

Which colormaps are those?
PerceptualColorMaps is a crazy heavy dependency, or at least it used to depend on the entire Images ecosystem

@asinghvi17
Copy link
Member Author

asinghvi17 commented Feb 9, 2023

Ouch, yeah it depends on Images and PyPlot as well. Might be best to just generate the colors and write the array out in MakieThemes.

Basically all the colormaps of ggthemr aren't represented in ColorSchemes. Another idea is that we could PR them over there.

@mkborregaard
Copy link
Collaborator

Yes that would be my suggestion
Colorschemes tries to be the hub of all things color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants