Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Supports adding light client custom nodes #375

Open
Danie0918 opened this issue Apr 2, 2024 · 8 comments
Open

[Feature Request] Supports adding light client custom nodes #375

Danie0918 opened this issue Apr 2, 2024 · 8 comments
Assignees
Labels

Comments

@Danie0918
Copy link
Contributor

To improve the network situation of the built-in nodes, it is recommended to add proxy settings. #nervosnetwork/neuron#3099

@Danie0918 Danie0918 self-assigned this Apr 2, 2024
@Danie0918 Danie0918 added this to Neuron Apr 2, 2024
@Danie0918 Danie0918 moved this to 📫Hold On in Neuron Apr 2, 2024
@Danie0918 Danie0918 moved this from 📫Hold On to 🆕 New in Neuron Apr 2, 2024
@Danie0918 Danie0918 moved this from 🆕 New to 🎨 Designing in Neuron Apr 7, 2024
@Danie0918
Copy link
Contributor Author

Danie0918 commented Apr 8, 2024

【Set proxy for internal full node or light client】

Image

  • Requirement Contents
  1. Add proxy settings to the network.
  2. The proxy will take effect for Neuron and internal nodes.

@Kirl70
Copy link

Kirl70 commented May 9, 2024

@Danie0918 Danie0918 assigned devchenyan and unassigned Danie0918 May 14, 2024
@Danie0918 Danie0918 moved this from 🎨 Designing to 🏗 In Progress in Neuron May 14, 2024
@Danie0918
Copy link
Contributor Author

Requires dependency node support: nervosnetwork/ckb#4473

@Keith-CY
Copy link
Member

Response from the core team at nervosnetwork/ckb#4473 (comment)

@Danie0918
Copy link
Contributor Author

Danie0918 commented Jun 25, 2024

It has been confirmed that the requirement can be solved by adding a custom light client node without the need to add proxy functionality.

@Danie0918 Danie0918 assigned Danie0918 and unassigned Danie0918 and devchenyan Jun 25, 2024
@Danie0918 Danie0918 moved this from 🏗 In Progress to 📌Planning in Neuron Jun 25, 2024
@Danie0918 Danie0918 moved this from 📌Planning to 🎨 Designing in Neuron Jun 25, 2024
@Danie0918 Danie0918 changed the title [Feature Request] Set proxy for internal full node or light client [Feature Request] Supports adding light client custom nodes Jul 5, 2024
@Danie0918 Danie0918 moved this from 🎨 Designing to 🏗 In Progress in Neuron Jul 8, 2024
@Danie0918 Danie0918 removed their assignment Jul 8, 2024
@Danie0918
Copy link
Contributor Author

Danie0918 commented Jul 8, 2024

Image

  • Requirement:
  1. 'Add network' add node type selection
  2. The node type is not selected by default and needs to be manually selected by the user.
  3. Unable to click the 'OK' button when node type is not selected.

Image

  • Requirement:
  1. Remove the light client node detection alert.
  2. The list of added nodes must match the detected node type.
  3. When adding a new network, the type is the same as the detection node type and cannot be modified.

@Kirl70
Copy link

Kirl70 commented Jul 8, 2024

@Danie0918
Copy link
Contributor Author

pr:nervosnetwork/neuron#3207

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🔎 Code Review in Neuron Jul 12, 2024
@Danie0918 Danie0918 moved this from 🔎 Code Review to 👀 Testing in Neuron Jul 18, 2024
@Danie0918 Danie0918 assigned silySuper and unassigned devchenyan Jul 18, 2024
@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Jul 29, 2024
@Danie0918 Danie0918 moved this from 🚩Pre Release to :octocat: Release List in Neuron Aug 1, 2024
@Danie0918 Danie0918 moved this from ⭐ Release List to 🚩Pre Release in Neuron Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🚩Pre Release
Development

No branches or pull requests

5 participants