-
Notifications
You must be signed in to change notification settings - Fork 114
Please provide CPU agnostic binaries of the native module. #131
Comments
This library requires OS-specific bindings compiled for a specific architecture, so I'm not sure what you mean by "CPU agnostic binaries"? As a convenience, the maintainers offer "prebuilds" of the bindings for the most common architectures. It sounds like what you're asking is to provide architecture-specific prebuilds for additional architectures? I don't understand what you're asking. |
It's also unclear to me what your question is and what you're asking for. Maybe you're looking for a rewrite with the N-API and make the code context-aware? There is a open PR for that but still needs some work: #127 |
Provide these binaries :) In electron apps - e.g. like VS the plugin is not recompiled if it is bundled. |
@egandro There are already Those are automatically used when you're installing the library ( |
There are some bugs with this:
microsoft/vscode-arduino#1207
#124
The main issue is an architecture specific module:
I don't really know how to handle this. In an enterprise enviornment we would go with a build farm, that is creating binaries for
No idea how we should deal with an Opensource project.
I guess - as Microsoft has an issue with this on VS Code for arm, too - you might get help. @adiazulay is the maintainer of the Arduino Plugin for VS Code.
Maybe we can just ripp the npm in parts? (make linux-x86_64 default and let the community deal with their archs)
Within the specific driver you provide a getVersion() and this must match the the main implementation?
The text was updated successfully, but these errors were encountered: