Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language (Hebrew or English) selection doesn't persist between pages. #284

Open
develad opened this issue May 19, 2024 · 7 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@develad
Copy link
Contributor

develad commented May 19, 2024

Description

The language (Hebrew or English) selection doesn't persist between pages. It worked just fine couple commits ago. Something must have been broken in the latest merges/ conflict fixes.

Screenshots

No response

Additional information

No response

@develad develad added the bug Something isn't working label May 19, 2024
@Darkmift
Copy link
Collaborator

cannot reproduce.
please provide more info or reproduction steps @develad

@develad
Copy link
Contributor Author

develad commented May 19, 2024

@Darkmift

2024-05-19.12-03-28.mp4

@keren-w
Copy link
Contributor

keren-w commented May 19, 2024

I added useTextDirection to ModalContent, this shouldn't have created it but I can try to find out. Do you want to assign me?
Seem to happen only in production.

@Darkmift Darkmift self-assigned this May 19, 2024
@Darkmift
Copy link
Collaborator

Darkmift commented May 19, 2024

I believe its fixed by:

please let me know

@develad
Copy link
Contributor Author

develad commented May 19, 2024

@Darkmift
The bug hasn't resolved

@Darkmift
Copy link
Collaborator

@barel-mishal @Tamir198
can you reproduce?

@Tamir198
Copy link
Contributor

Tamir198 commented Jun 1, 2024

Yes, changing language of the main page is not consistent with the "who are we" page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants