Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

mining v2 - iOS auto claim issue #235

Open
reasje opened this issue Jul 4, 2024 · 10 comments
Open

mining v2 - iOS auto claim issue #235

reasje opened this issue Jul 4, 2024 · 10 comments
Assignees

Comments

@reasje
Copy link
Contributor

reasje commented Jul 4, 2024

No description provided.

@reasje reasje self-assigned this Jul 4, 2024
@reasje
Copy link
Contributor Author

reasje commented Jul 4, 2024

This error was caused by the injection in IOS and the injection doesn't occur properly, And the error JavaScript execution returned a result of an unsupported type is thrown on JS side which means the injections doesn't take place.

@reasje
Copy link
Contributor Author

reasje commented Jul 4, 2024

Dev log:
However surprisingly the injection occured and AXS object was available, However the error seems to interupt the axs JS channel detection by the web app.

@reasje
Copy link
Contributor Author

reasje commented Jul 4, 2024

Dev log :
I was able to find the error in Stackoverflow, However two injection that the other one was related to webview copy handler injection also had this problem and added to confusion to fix the bug.
Finally the bug was fixed by wrapping the JS code to function call and the error in IOS was about evaluating a statement that has Nil return type (Which is OK too and the strange behavior from IOS).

@reasje
Copy link
Contributor Author

reasje commented Jul 4, 2024

@SanghamitraBhowmick1993
I would appriciate If you can test both Android and IOS because the changes reflected both, The changes are about the JS channel meaning testing miner dapp auto claim functionality including passing miner can confirm the fix.

@reasje
Copy link
Contributor Author

reasje commented Jul 4, 2024

@SanghamitraBhowmick1993
Plz note that I have pushed all the changes so far, I have commented the interfaces for the user not to access new features.

@reasje
Copy link
Contributor Author

reasje commented Jul 5, 2024

Dev log:
IOS 17.5.1 Not working
IOS 17.4.0 Working
IOS 16.2.0 Not working

@reasje
Copy link
Contributor Author

reasje commented Jul 6, 2024

Dev log:
IOS 17 is working

@reasje
Copy link
Contributor Author

reasje commented Jul 6, 2024

The injection happens and the object is visible right after injection but the detection seems to be problematic.

@reasje
Copy link
Contributor Author

reasje commented Jul 8, 2024

Dev log:
AXS wallet announcement to web app delayed, This can fix the issue with JS channel, 17.5 & 17.4 are OK so far.

@reasje
Copy link
Contributor Author

reasje commented Jul 8, 2024

@SanghamitraBhowmick1993
I have pushed the fix for the AXS not being detected on web app, It would be great If you can check on Android and other IOS versions, In my case Simulator 17.4 & 17.5 are working as expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant