fix: Memory error during checksum validation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…memory error on system with low RAM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
This pull request addresses a MemoryError issue encountered when computing the SHA256 checksum for validation of each downloaded tar
Changes:
Modified the compute_sha256 function to read files in chunks rather than loading them entirely into memory.
Verified the fix, the script is able to run without a crash
Included screenshots demonstrating the issue before the fix and the successful execution after the fix.
Added system memory usage information (free -h) to provide context for a system where the issue should be replicable
Screenshots:
Screenshot 1: Error encountered when processing a download
Screenshot 2: Successful execution after implementing chunked reading
System Memory Usage
