Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer - Issue in PitchYINFFT when no peaks are detected. #1378

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Framebuffer - Issue in PitchYINFFT when no peaks are detected. #1378

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90c316f
Fix issue in PitchYINFFT when no peaks were found by PeakDetection.
xaviliz Sep 19, 2023
043df33
Revert "Fix issue in PitchYINFFT when no peaks were found by PeakDete…
xaviliz Sep 19, 2023
ee31729
Fix issue in PitchYINFFT when no peaks were found by PeakDetection.
xaviliz Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/algorithms/tonal/pitchyinfft.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,9 @@ void PitchYinFFT::compute() {
yinMin = -_amplitudes[0];
}
else {
// TODO this should never happen, but some people reported it happening in their real time applications.
throw EssentiaException("PitchYinFFT: it appears that no peaks were found by PeakDetection. If you read this message, PLEASE, report this issue to the developers with an example of audio on which it happened.");
tau = 0.0; // it will provide zero-pitch and zero-pitch confidence.
// launch warning message for user feedbacking
E_WARNING("PitchYinFFT: it appears that no peaks were found by PeakDetection algorithm. So, pitch and confidence will be set to zero.");
}
}
else {
Expand Down
Loading