Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dependencies #18

Open
kadykov opened this issue Aug 7, 2023 · 1 comment
Open

Simplify dependencies #18

kadykov opened this issue Aug 7, 2023 · 1 comment

Comments

@kadykov
Copy link
Contributor

kadykov commented Aug 7, 2023

Since the tmm-fast is published on pipy.org I think it is better to keep dependencies as minimal as possible.

For instance, it would be better to remove dask from dependencies, as it is not directly used anywhere in the project.

The main functionality in vectorized_tmm_dispersive_multistack.py and tmm_fast_torch.py does not require gymnasium, matplotlib and seaborn, therefore we can declare them as optional ones.

Probably, it could be even better to split the TMM and AI functionality into two separate projects...

@Nerrror
Copy link
Collaborator

Nerrror commented Aug 7, 2023

You're right, it might be a good idea to split the TMM and AI functionality and add a second project which then builds on TMM for the RL environment.
This could be implemented in the next main version or so. I'm working on an extension for incoherent layers right now so this issue might take a while to implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants