Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of an equivalent to tmm.tmm_core.inc_tmm() #16

Open
superluminescent opened this issue Jun 20, 2023 · 2 comments
Open

Implementation of an equivalent to tmm.tmm_core.inc_tmm() #16

superluminescent opened this issue Jun 20, 2023 · 2 comments

Comments

@superluminescent
Copy link

Hi again,
I was wondering if there are any plans to implement a vectorized version of the "incoherent, or partly-incoherent-partly-coherent, transfer matrix method" as implemented in the original tmm package by S. Byrnes?

For one of my projects, I reproduced the original functionality for a particular case (fitting to FTIR data of a DBR on a thick bulk slab, with vacuum as a sub- and superstrate).

I imagine that the partly-coherent method might benefit people in similar use cases, both in measurement and simulation.

My crude implementation already resulted in a considerable speed improvement compared to the original tmm code. If you're interested, I could take a deeper dive to generalize and optimize the code further for a possible contribution to tmm_fast.

I'm open to discussing this further should you be interested.

Best, superluminescent

@pwilliam123
Copy link

Hi, @superluminescent
I'm interesting in the vectorized version of the "incoherent, or partly-incoherent-partly-coherent, transfer matrix method", is there any source that you could share ?

@Nerrror
Copy link
Collaborator

Nerrror commented Sep 8, 2023

@superluminescent the incoherent method is now implemented in the develop branch and should work. I haven't tested gradients yet but the reflectivitiy and transsmissivity computation seems correct.

@pwilliam123 in this paper, S. Byrnes explains how the coherent and also incoherent mehtod works. The tmm-fast implementation also follows his naming convention, so if you're interested you should see the similarities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants