-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read MDS in tiles using Zarr #331
Draft
castelao
wants to merge
16
commits into
MITgcm:master
Choose a base branch
from
castelao:feat/mds_tilez
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing collect_meta(). Let's process per variable, so the first step is to collect all meta and group per variable.
I'll collect everything here until I understand where it fits in the library.
Understanding and validating the connections between zarr and MITgcm's binaries. Once I validated a working reader, I can start to generalize it.
Test driven development. Let's start with a hardcoded behavior and later generalize it as I understand what is required.
Using lat as an easy case to start.
Still using a hardcoded case to understand the requirements for VarZ.
Trying a different concept and adding a few resources.
Chunk() is an auxiliary class to organize and collect information from meta, while VarZ keep track of all chunks for one variable.
I was testing with @rabernat 's proof of concept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prototype based on the concept proposed by @rabernat at #28.
Scans for
meta
files and creates an equivalent Zarr mapping usingReferenceFileSystem
to read tiles. It works but it is not ready for production. It is missing docs, generalize my local tests, cleaning, ...@mmazloff , this might be useful to you.