Bump the github-actions group with 8 updates #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the github-actions group with 8 updates: | Package | From | To | | --- | --- | --- | | [actions/download-artifact](https://github.com/actions/download-artifact) | `3` | `4` | | [tj-actions/changed-files](https://github.com/tj-actions/changed-files) | `39` | `42` | | [actions/setup-python](https://github.com/actions/setup-python) | `4` | `5` | | [actions/github-script](https://github.com/actions/github-script) | `6` | `7` | | [actions/setup-node](https://github.com/actions/setup-node) | `3` | `4` | | [actions/labeler](https://github.com/actions/labeler) | `4` | `5` | | [ossf/scorecard-action](https://github.com/ossf/scorecard-action) | `2.1.2` | `2.3.1` | | [github/codeql-action](https://github.com/github/codeql-action) | `2.2.4` | `3.24.5` | Updates `actions/download-artifact` from 3 to 4 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) Updates `tj-actions/changed-files` from 39 to 42 - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v39...v42) Updates `actions/setup-python` from 4 to 5 - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) Updates `actions/github-script` from 6 to 7 - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v6...v7) Updates `actions/setup-node` from 3 to 4 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) Updates `actions/labeler` from 4 to 5 - [Release notes](https://github.com/actions/labeler/releases) - [Commits](actions/labeler@v4...v5) Updates `ossf/scorecard-action` from 2.1.2 to 2.3.1 - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@e38b190...0864cf1) Updates `github/codeql-action` from 2.2.4 to 3.24.5 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@17573ee...47b3d88) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/github-script dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/labeler dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
Superseded by #19. |
dependabot
bot
deleted the
dependabot/github_actions/github-actions-bd8a0a1526
branch
djtodoro
pushed a commit
that referenced
this pull request
Nov 22, 2024
…onger cause a crash (#116569)
This PR fixes a bug introduced by #110199, which causes any half float
argument to crash the compiler on MIPS64.
Currently compiling this bit of code with `llc -mtriple=mips64`:
```
define void @half_args(half %a) nounwind {
entry:
ret void
}
```
Crashes with the following log:
```
LLVM ERROR: unable to allocate function argument #0
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0. Program arguments: llc -mtriple=mips64
1. Running pass 'Function Pass Manager' on module '<stdin>'.
2. Running pass 'MIPS DAG->DAG Pattern Instruction Selection' on function '@half_args'
#0 0x000055a3a4013df8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x32d0df8)
#1 0x000055a3a401199e llvm::sys::RunSignalHandlers() (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x32ce99e)
#2 0x000055a3a40144a8 SignalHandler(int) Signals.cpp:0:0
#3 0x00007f00bde558c0 __restore_rt libc_sigaction.c:0:0
#4 0x00007f00bdea462c __pthread_kill_implementation ./nptl/pthread_kill.c:44:76
#5 0x00007f00bde55822 gsignal ./signal/../sysdeps/posix/raise.c:27:6
#6 0x00007f00bde3e4af abort ./stdlib/abort.c:81:7
#7 0x000055a3a3f80e3c llvm::report_fatal_error(llvm::Twine const&, bool) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x323de3c)
#8 0x000055a3a2e20dfa (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x20dddfa)
#9 0x000055a3a2a34e20 llvm::MipsTargetLowering::LowerFormalArguments(llvm::SDValue, unsigned int, bool, llvm::SmallVectorImpl<llvm::ISD::InputArg> const&, llvm::SDLoc const&, llvm::SelectionDAG&, llvm::SmallVectorImpl<llvm::SDValue>&) const MipsISelLowering.cpp:0:0
#10 0x000055a3a3d896a9 llvm::SelectionDAGISel::LowerArguments(llvm::Function const&) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x30466a9)
#11 0x000055a3a3e0b3ec llvm::SelectionDAGISel::SelectAllBasicBlocks(llvm::Function const&) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x30c83ec)
#12 0x000055a3a3e09e21 llvm::SelectionDAGISel::runOnMachineFunction(llvm::MachineFunction&) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x30c6e21)
#13 0x000055a3a2aae1ca llvm::MipsDAGToDAGISel::runOnMachineFunction(llvm::MachineFunction&) MipsISelDAGToDAG.cpp:0:0
#14 0x000055a3a3e07706 llvm::SelectionDAGISelLegacy::runOnMachineFunction(llvm::MachineFunction&) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x30c4706)
#15 0x000055a3a3051ed6 llvm::MachineFunctionPass::runOnFunction(llvm::Function&) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x230eed6)
#16 0x000055a3a35a3ec9 llvm::FPPassManager::runOnFunction(llvm::Function&) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x2860ec9)
#17 0x000055a3a35ac3b2 llvm::FPPassManager::runOnModule(llvm::Module&) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x28693b2)
#18 0x000055a3a35a499c llvm::legacy::PassManagerImpl::run(llvm::Module&) (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x286199c)
#19 0x000055a3a262abbb main (/home/davide/Ps2/rps2-tools/prefix/bin/llc+0x18e7bbb)
#20 0x00007f00bde3fc4c __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3
#21 0x00007f00bde3fd05 call_init ./csu/../csu/libc-start.c:128:20
#22 0x00007f00bde3fd05 __libc_start_main@GLIBC_2.2.5 ./csu/../csu/libc-start.c:347:5
#23 0x000055a3a2624921 _start /builddir/glibc-2.39/csu/../sysdeps/x86_64/start.S:117:0
```
This is caused by the fact that after the change, `f16`s are no longer
lowered as `f32`s in calls.
Two possible fixes are available:
- Update calling conventions to properly support passing `f16` as
integers.
- Update `useFPRegsForHalfType()` to return `true` so that `f16` are
still kept in `f32` registers, as before #110199.
This PR implements the first solution to not introduce any more ABI
changes as #110199 already did.
As of what is the correct ABI for halfs, I don't think there is a
correct answer. GCC doesn't support halfs on MIPS, and I couldn't find
any information on old MIPS ABI manuals either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the github-actions group with 8 updates:
343942456734452.1.22.3.12.2.43.24.5Updates
actions/download-artifactfrom 3 to 4Release notes
Sourced from actions/download-artifact's releases.
Commits
87c5514Merge pull request #303 from bethanyj28/main47f9ce6update@actions/artifact127824dMerge pull request #299 from bethanyj28/main6dd49bflicensed only artifactf71c0e3Revert "licensed"7c63dfdlicensed67d37cdUpdate toolkit3487549Update release-new-action-version.yml (#292)eaceaf8Merge pull request #291 from actions/eggyhead/update-artifact-v2.1.181eafdcupdate artifact licenseUpdates
tj-actions/changed-filesfrom 39 to 42Release notes
Sourced from tj-actions/changed-files's releases.
... (truncated)
Changelog
Sourced from tj-actions/changed-files's changelog.
... (truncated)
Commits
800a282chore(deps): lock file maintenance31c4d15Added missing changes and modified dist assets.2a2a5b6fix(deps): update dependency yaml to v2.4.0d8dcc13chore: Update README.md (#1952)639ce0echore(deps): update dependency eslint to v8.57.09d447b9Added missing changes and modified dist assets.83bfc72chore(deps): lock file maintenance879c838chore(deps): update dependency@types/nodeto v20.11.20bb7502bUpdate README.md5c5539cchore(deps): update typescript-eslint monorepo to v7.0.2Updates
actions/setup-pythonfrom 4 to 5Release notes
Sourced from actions/setup-python's releases.
... (truncated)
Commits
0a5c615Update action to node20 (#772)0ae5836Add example of GraalPy to docs (#773)b64ffcaupdate actions/checkout to v4 (#761)8d28961Examples now use checkout@v4 (#738)7bc6abbadvanced-usage.md: Encourage the use actions/checkout@v4 (#729)e8111ceBump@babel/traversefrom 7.9.0 to 7.23.2 (#743)a00ea43add fix for graalpy ci (#741)8635b1cChange deprecation comment to past tense (#723)f6cc428Use non-deprecated versions in examples (#724)5f2af21Add GraalPy support (#694)Updates
actions/github-scriptfrom 6 to 7Release notes
Sourced from actions/github-script's releases.
... (truncated)
Commits
60a0d83Merge pull request #440 from actions/joshmgross/v7.0.1b7fb200Update version to 7.0.112e22edMerge pull request #439 from actions/joshmgross/avoid-setting-base-urld319f8fAvoid settingbaseUrlto undefined when input is not providede69ef54Merge pull request #425 from actions/joshmgross/node-20ee0914bUpdate licensesd6fc56fUse@types/nodefor Node 20384d6cfFix quotations in tests8472492Only validate GraphQLpreviews84903f5Removenode-fetchfrom typeUpdates
actions/setup-nodefrom 3 to 4Release notes
Sourced from actions/setup-node's releases.
... (truncated)
Commits
60edb5dAdd support for arm64 Windows (#927)d86ebcdAdd support forvolta.extends(#921)b39b52dFix node-version-file interprets entire package.json as a version (#865)7247617Addpackage.jsontonode-version-filelist of examples. (#879)f3ec4caFix README.md (#898)ec97f37Add fix for cache (#917)5ef044fUpdate reusable workflows to use Node.js v20 (#889)c45882aupdate to setup-node@v4 in docs (#884)ee36e8bIgnore engines check in Yarn 1 e2e-cache tests (#882)8f152deUpdate actions/checkout for documentation and yaml (#876)Updates
actions/labelerfrom 4 to 5Release notes
Sourced from actions/labeler's releases.
... (truncated)
Commits
8558fd7Merge pull request #709 from actions/v5.0.0-beta000ca75Merge pull request #700 from MaksimZhukov/apply-suggestions-and-update-docume...cb66c2fUpdate dist9181355Apply suggestions for the beta vesrion and update the documentationefe4c1cMerge pull request #699 from MaksimZhukov/update-node-runtime-and-dependenciesc0957adRun Prettier8dc8d18Update Node.js version in reusable workflowsd0d0bbeUpdate documentation1375c425.0.0ab7411eChange version of Node.js runtime to node20Updates
ossf/scorecard-actionfrom 2.1.2 to 2.3.1Release notes
Sourced from ossf/scorecard-action's releases.
... (truncated)
Commits
0864cf1🌱 Bump docker tag to for v2.3.1 release (#1284)72df3bf🌱 Bump github.com/ossf/scorecard/v4 from v4.13.0 to v4.13.1 (#1282)0ea411f🌱 Bump the docker-images group with 1 update (#1281)dbfd042🌱 Bump the github-actions group with 1 update (#1280)2fa1e2f🌱 Bump golang.org/x/net from 0.16.0 to 0.17.0 (#1278)652ddd0🌱 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (#1277)28d0c92🌱 Group Dependabot updates for GitHub Actions and Dockerfiles (#1276)cb50491🌱 Bump distroless/base froma35b652tob31a6e0(#1275)87157ac🌱 Bump github/codeql-action from 2.21.9 to 2.22.1 (#1274)7c1648b🌱 Bump step-security/harden-runner from 2.5.1 to 2.6.0 (#1273)Updates
github/codeql-actionfrom 2.2.4 to 3.24.5Release notes
Sourced from github/codeql-action's releases.