Experimental -- moving if(just_dydt)
guard in net_derivs
#745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking to see if this fixes:
#733
Test results here: https://testhub.mesastar.org/bugfix%2Fpmocz%2Fonezone/commits/2e2893f
The idea is that I move the guard
if (just_dydt) return
a few lines down, so thateps_nuc_MeV
always gets updated in the functions:{
get_general_1_to_1_derivs()
,get_general_2_to_1_derivs()
,get_general_2_to_2_derivs()
,get_basic_2_to_2_derivs()
,get_basic_2_to_1_derivs()
}because that is what happens in
update_special_rates()
andget1_derivs()
.(i.e. bringing logical consistency to the parent function:
get_derivs()
)@fxt44 is this change correct? Feels like a big change and I would not want to mess anything up. It is hard for me to know what's right because MESA is acting like a "state-machine" over here