Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental -- moving if(just_dydt) guard in net_derivs #745

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmocz
Copy link
Member

@pmocz pmocz commented Oct 29, 2024

Checking to see if this fixes:

#733

Test results here: https://testhub.mesastar.org/bugfix%2Fpmocz%2Fonezone/commits/2e2893f

The idea is that I move the guard if (just_dydt) return a few lines down, so that eps_nuc_MeV always gets updated in the functions:

{get_general_1_to_1_derivs(), get_general_2_to_1_derivs(), get_general_2_to_2_derivs(), get_basic_2_to_2_derivs(), get_basic_2_to_1_derivs()}

because that is what happens in update_special_rates() and get1_derivs().

(i.e. bringing logical consistency to the parent function: get_derivs())

@fxt44 is this change correct? Feels like a big change and I would not want to mess anything up. It is hard for me to know what's right because MESA is acting like a "state-machine" over here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant