Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited CWL support #26

Closed
LourensVeen opened this issue Apr 3, 2017 · 5 comments
Closed

Limited CWL support #26

LourensVeen opened this issue Apr 3, 2017 · 5 comments

Comments

@LourensVeen
Copy link
Member

LourensVeen commented Apr 3, 2017

There is currently no support for:

  • secondaryFiles
  • contents field (semantics of locations vs. path vs. contents is murky...)
@LourensVeen LourensVeen changed the title Doesn't support secondaryFiles Limited CWL support Apr 3, 2017
@LourensVeen
Copy link
Member Author

Also, there's no support for basename. According to the spec, if you give a location and a basename, the file should be downloaded from location and saved as basename. We currently ignore basename, and create a unique identifier ourselves.

It will probably still work however, since we pass the original input binding with only a modified location to cwltool, which should then do the rename.

@LourensVeen
Copy link
Member Author

After careful study of the spec, and consideration of the fact that it's just an attempt at codifying the behaviour of cwltool, it seems that one should normally specify only location and perhaps basename if that is required. The implementation will then generate path for use with scripts inside the CWL. Alternatively, you can pass only contents, and cwltool will make it look like those were downloaded from somewhere. Specifying only path may or may not work; if it does it gets the file from the local file system. You're better off using a file:/// location then however.

@LourensVeen
Copy link
Member Author

Also we're currently not supporting Directory inputs, which should be fairly simple, as it's just like staging a File, except you do a recursive copy.

@LourensVeen
Copy link
Member Author

secondaryFiles now works, and basename does as well, so it's just Directory now.

@LourensVeen
Copy link
Member Author

Which is actually issue #46, so closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant