Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuration merging #29

Open
chuckwondo opened this issue Apr 6, 2022 · 0 comments
Open

Support configuration merging #29

chuckwondo opened this issue Apr 6, 2022 · 0 comments

Comments

@chuckwondo
Copy link
Contributor

The maap.maap.MAAP expects to find a maap.cfg file in one of the following locations:

  • current directory
  • user's home directory
  • location specified by MAAP_CONF environment variable

Unfortunately, it uses only the first one it finds, making it impossible to simply override a subset of configuration values (not even a single override). This prevents setting up a maap.cfg file with defaults, and then simply providing an additional maap.cfg file containing only overrides.

Since ConfigParser is used, "merging" is already supported, so the code changes required should be minimal.

Further, implementation of this should be accompanied by clear documentation on supported file locations, as well as the order of precedence, such that it is clear as to which location has lowest precedence (and thus may be used for "default"), and which other locations have increasing precedence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant