-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increasing fps also increases rain falling speed #27
Comments
Well the fall speed property is in units of steps so it's relative to the steps per second property. This could probably be better explained in the help section. Is there a specific behavior you are looking for configuring? |
I want the smoothness of 60 fps, but without the insane speed. |
I don't know how smooth 10 changes per second can look. The frame rate could be increased to always be 60 fps, though my guess is that rendering something 5 times more that in needs would just make it costlier but it doesn't hurt to try. If anything the issue probably lies in the exact sync between app, terminal and screen and I don't have an idea how this would be addressed other than empirically. Of course, the amount of processing can also have an effect. As for the fractional speeds, this is already in the works, though as a separate idea from this. |
i'll try it in the coming days |
I tried the 60 fps version, and it has the same problems {as described above) as the release version. I think the only solution to this is to decouple the fall speed from the number of steps taken. |
They are kinda decoupled in the 60 fps version so I don't know what better thing you have in mind and why do you think it would work if this didn't? |
The newest version has fractional falling speeds. Can you test it out and see if it makes any difference? |
Just tested it, and now i can get the desired falling speed at 60 fps. Next step would be to remove the frame rate cap completely. |
Oh that's great! You can apply this diff to try out how it looks without a frame rate cap. |
After short testing, it seems to be working well without the frame rate cap. |
Setting the speed to What do you think about adding your setting as a new mode ( |
I think |
Ok, I'll add the mode and credit you if you're ok with that. |
Currently the default value for
--steps-per-sec
of 10 looks choppy. But when you set it higher, it also raises the rain falling speed, separately from the-fall-speed
setting.At 60 steps you cannot even see the characters properly, because they fall so fast, even if you set
-f 0,1
.The text was updated successfully, but these errors were encountered: