Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Subtract already-owned ingredients from shopping list #62

Open
langston-barrett opened this issue Jul 8, 2018 · 3 comments
Open
Assignees

Comments

@langston-barrett
Copy link
Collaborator

This would be a two-part enhancement. Please correct me if any of my observations are mistaken.

It seems to me that shop simply concatenates the list of ingredients of the desired recipes. In the case that I'm making two recipes, each of which calls for limes, it seems that I'll get two lines in the output, each with different quantities of limes. So enhancement (1) would be to smartly combine the ingredients with identical, or better, inter-convertible units.

Once this is done, herms could also take in a list (from a file?) of ingredients the user already has, and remove them from the shopping list (or reduce the quantity in the list by the relevant amount).

I would be very happy to implement this!

@LuxMiranda
Copy link
Owner

Seems like an awesome idea!

@langston-barrett
Copy link
Collaborator Author

Enhancement (1) as described above is implemented in #71.

@langston-barrett
Copy link
Collaborator Author

langston-barrett commented Sep 10, 2018

I have a branch with this feature in the works, just waiting on #76:

https://github.com/JackMiranda/herms/compare/master...siddharthist:pantry-rebased?expand=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants