-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search through recipes given a keyword #36
Comments
Hey there, I think I could work on this. |
@renanpvaz That sounds wonderful! Please comment here or email me if any questions come up. As you begin coding, you may want to take a look at #76, which makes some significant changes and should be merged soon(ish) (to be sure we don't end up with conflicting changes). |
Early implementation in #123. However, colorization and bolding still need to be added, as well as support for multiple regular expressions at once. Should we bold the titles of the matching recipes? Or the string matches? |
What would be the advantage of multiple regexes (
I'd say the string matches, but that's just personal preference. I'm not too picky as long as it looks good! |
I think it's more user friendly to be able to specify multiple regexes in sequence, but if a user actually uses regex features instead of just strings, I figure they would know how to use unions as well. Just a thought. I'll take a look into colorizing the string match output when I get a chance, really busy week :( |
Fair enough, that's basically what I expected but wanted to be sure I wasn't missing anything. I'm happy either way (if we have support for multiple regexes or not).
Sure thing, no need to hold up a nice new feature with window dressing. |
I'm thinking of something similar to
grep
but that searches instead through recipes. For now, just search through whatshowRecipe
would typically display, we can get fancier later!The interaction might look something like this:
You can see here that the recipe index and recipe name are given followed by the relevant line of text that has been found. Sometimes it finds the word in the title, sometimes in the ingredients, sometimes in the directions. It just needs to be a simple "I found the string you're looking for on this line!"
Tips:
grep
. Bold/color the output in a similar fashion.showRecipe
function and all of its many facetsGood luck! Throw questions this way if you have any :)
The text was updated successfully, but these errors were encountered: