Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config doesn't work with custom date format other than the default #76

Open
jonth93 opened this issue Jul 4, 2023 · 5 comments
Open

Comments

@jonth93
Copy link

jonth93 commented Jul 4, 2023

To get the filter to work correctly, the default date format has to be preserved:

'altFormat' => 'F j, Y', // The date format to be displayed once a date is selected
'ariaDateFormat' => 'F j, Y', // The date format to be displayed for screen-readers
'dateFormat' => 'Y-m-d', // The date format to be returned for use in the filter
'earliestDate' => '2022-01-01', // The earliest date permitted, this is not required
'latestDate' => date('Y-m-d') // The latest date permitted, this is not required

I cannot change the dateFormat to d-m-Y as the filter fails to apply?

@jonth93
Copy link
Author

jonth93 commented Jul 4, 2023

This also results in the pill returning and empty string

@lrljoe
Copy link
Member

lrljoe commented Jul 28, 2023

Is this still the case? If so, I'll take a look at this one sooner rather than later.

@jonth93
Copy link
Author

jonth93 commented Aug 12, 2023

Hi, yes this is still the case

@lrljoe
Copy link
Member

lrljoe commented Aug 14, 2023

Currently reviewing this, and will put a fix together by the end of the week.

However, v3 of the core Rappasoft package will include the DateRange and NumberRange filters.

I am trying to get any remaining extra filters into the pipeline. But please do join the official Rappasoft Discord for more updates.

@lrljoe
Copy link
Member

lrljoe commented Aug 26, 2023

This is fixed in the v3 beta, and I'll be backporting some fixes into v2 once v3 is stable and released. If you're going to Livewire 3, then definitely check out the core Rappasoft V3 beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants