Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not predict the PPB fraction for some molecules #1

Open
carcablop opened this issue Feb 16, 2023 · 2 comments
Open

Not predict the PPB fraction for some molecules #1

carcablop opened this issue Feb 16, 2023 · 2 comments

Comments

@carcablop
Copy link

carcablop commented Feb 16, 2023

Hello.
I am trying to use this work to predict the PPB fractions. I am passing as input this file "eml_canonicals.csv". This is the input file: eml_canonical.csv
which contains the smiles that I want to calculate the ppb fractions.
But I find that the model does not predict the ppb fractions for some smiles. They are the following:

[CaH2]
[F-]
[I]
O
[Cl-].[K+]
[I-].[K+]
S
N.N.[Ag+].[F-]
[Cl-].[Na+]

I approach you to ask, Why for these molecules it is not possible to calculate the PPB values? and Why not taken into account in the final output?.
If you like, you can take a look at the work we are doing in Ersilia to incorporate this model: ersilia-os/ersilia#590. This is the link to the issue where we are following up to address this model. ersilia-os/ersilia#590 (comment)

Thanks in advance.
I appreciate an answer, to achieve a clear justification of what other alternatives we could address to deal with these molecules.

@Louchaofeng
Copy link
Owner

Louchaofeng commented Feb 17, 2023 via email

@carcablop
Copy link
Author

carcablop commented Feb 20, 2023

Hello @Louchaofeng.

Thanks a lot for the answer.
This information has been very clear to us and very useful. We will take this into account in the interpretation of the model output.

Thank you.

Carolina Caballero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants