Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove redundant path from arm release #191

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Fei1Yang
Copy link
Contributor

@Fei1Yang Fei1Yang commented Dec 11, 2024

Sync arm release to have the same behavior x86 release currently has, with no bundle root directory in it's release package.

Summary by Sourcery

Align ARM release packaging with x86 by removing the redundant 'bundle' directory from the release package and updating the CI configuration accordingly.

Bug Fixes:

  • Remove redundant 'bundle' directory from ARM release package to align with x86 release behavior.

CI:

  • Update CI configuration to change the packaging path for ARM release.

Copy link

sourcery-ai bot commented Dec 11, 2024

Reviewer's Guide by Sourcery

This PR modifies the ARM release packaging process in CircleCI to remove a redundant bundle directory from the release package. The change aligns the ARM release structure with the existing x86 release package format.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified the ARM release packaging process in CircleCI
  • Changed working directory to include 'bundle' in the path before creating zip
  • Updated zip command to package from current directory instead of 'bundle' subdirectory
  • Modified zip output path to parent directory to maintain correct package name
.circleci/config.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Fei1Yang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 4011830 into Losses:master Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants