Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macOS): Hide window control buttons when enable cover wall in zune and phone size #190

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Dec 10, 2024

Summary by Sourcery

New Features:

  • Hide window control buttons on macOS when the application is in Zune or Phone size and the cover wall is enabled.

Copy link

sourcery-ai bot commented Dec 10, 2024

Reviewer's Guide by Sourcery

This PR modifies the window control buttons visibility logic for macOS, specifically handling their visibility when the cover wall is enabled in Zune and Phone device types. The implementation updates the updateWindowControlButtons method to include additional conditions for hiding the window controls.

Class diagram for _WindowFrameForMacOSState changes

classDiagram
    class _WindowFrameForMacOSState {
        - FullScreenProvider _fullscreen
        - ResponsiveProvider _responsiveProvider
        + void didChangeDependencies()
        + void updateWindowControlButtons()
    }
    class MacOSWindowControlButtonManager {
        + static MacOSWindowControlButtonManager shared
        + void setHide()
        + void setShow()
        + void setVertical()
    }
    class ResponsiveProvider {
        + DeviceType currentDeviceType
    }
    class DeviceType {
        <<enumeration>>
        band
        dock
        zune
        phone
    }
    _WindowFrameForMacOSState --> MacOSWindowControlButtonManager
    _WindowFrameForMacOSState --> ResponsiveProvider
    ResponsiveProvider --> DeviceType
Loading

File-Level Changes

Change Details Files
Refactored window control buttons visibility logic
  • Extracted device type into a local variable for better readability
  • Added new condition to hide controls when in cover wall view for Zune and Phone devices
  • Restructured the method with early returns for better flow control
  • Maintained existing behavior for band and dock device types
lib/widgets/title_bar/window_frame_for_macos.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider injecting the router or passing the current path as a parameter instead of accessing $router globally, to improve testability and make dependencies explicit
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 5cdcb81 into master Dec 11, 2024
1 of 2 checks passed
@XMLHexagram XMLHexagram deleted the window-control-button-hide branch December 11, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants