Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add file extension to AppStream launchable field #186

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Fei1Yang
Copy link
Contributor

@Fei1Yang Fei1Yang commented Dec 7, 2024

When it means desktop-id, it actually means desktop-file.

Summary by Sourcery

Bug Fixes:

  • Correct the AppStream launchable field by adding the file extension to the desktop-id.

When it means desktop-id, it actually means desktop-file.

Signed-off-by: Fei1Yang <[email protected]>
Copy link

sourcery-ai bot commented Dec 7, 2024

Reviewer's Guide by Sourcery

This PR fixes the AppStream metadata by adding the .desktop file extension to the launchable field in the metainfo XML file. The change ensures proper desktop integration by correctly referencing the desktop entry file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update AppStream launchable field to include the .desktop extension
  • Change launchable desktop-id from 'rune' to 'rune.desktop'
  • Fix compliance with AppStream specification for desktop entry references
assets/source/linux/rune.metainfo.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Fei1Yang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 0caf1f2 into Losses:master Dec 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants