Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add assets to Linux release package #181

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Fei1Yang
Copy link
Contributor

@Fei1Yang Fei1Yang commented Dec 5, 2024

Add basic assets to Linux release package to fulfill part of Flathub's submission requirements (flathub/flathub#5907)

Summary by Sourcery

Add assets to the Linux release package to comply with Flathub's submission requirements, and update CI workflows to incorporate these assets into the build process.

New Features:

  • Add basic assets to the Linux release package, including icons and metadata files, to meet Flathub's submission requirements.

CI:

  • Update CircleCI and GitHub Actions workflows to include steps for adding assets to the Linux build.

Copy link

sourcery-ai bot commented Dec 5, 2024

Reviewer's Guide by Sourcery

This PR adds necessary assets to the Linux release package to meet Flathub submission requirements. The implementation involves modifying CI configuration files to copy icons and metadata files into the Linux build bundle, and adding new Linux-specific asset files.

Class diagram for new Linux asset files

classDiagram
    class Component {
        +String id
        +String name
        +String summary
        +String metadata_license
        +String project_license
        +List~String~ supports
        +String developer_name
        +String description
        +String content_rating
        +String launchable
        +List~Screenshot~ screenshots
        +List~Release~ releases
    }

    class Screenshot {
        +String type
        +String image
        +String caption
    }

    Component "1" -- "*" Screenshot

    class RuneDesktop {
        +String content
    }

    note for Component "Represents the rune.metainfo.xml file"
    note for RuneDesktop "Represents the rune.desktop file"
Loading

File-Level Changes

Change Details Files
Added Linux-specific metadata files for Flathub submission
  • Created AppStream metadata file with application description and screenshots
  • Added desktop entry file for Linux desktop integration
assets/source/linux/rune.metainfo.xml
assets/source/linux/rune.desktop
Updated CI configurations to include assets in Linux build bundle
  • Added new step to create assets directory in build bundle
  • Added commands to copy Papirus icons to build bundle
  • Added commands to copy Linux-specific assets to build bundle
.circleci/config.yml
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Fei1Yang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using variables or shared steps for the asset paths in CI configs to avoid duplication between arm64 and x64 builds
  • The releases section in rune.metainfo.xml is empty - consider adding current version information to meet Flathub requirements
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 0716ecb into Losses:master Dec 5, 2024
2 checks passed
@Fei1Yang Fei1Yang deleted the linux-release-assets branch December 7, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants