-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving forward + better web support #302
Comments
Heya @sreuter, I'd love to help :) post messages as an alternate to injectJs sounds fine on initial impressions. |
Awesome, we'll push a bit further on this then and hopefully have a first PR up and ready soon :) |
@sreuter @LonelyCpp how is the situation on this? I'd like to contribute, for example adding progress event |
@LonelyCpp @sreuter any update about this? |
@sreuter @LonelyCpp how can we help you on this challenge? im need this feature too. I have an app working in all platforms, but in web this lib not work. |
Consider using |
some updates on this : I've tested play, pause and mute events with post messages - f56441d works quite well! I'll start moving other things to post messages as well & hopefully we'll have full support on rn-web too. Stay tuned! |
Describe the bug
The current state of YouTube embedding across ReactNative iOS, Android & Web is pretty sad. Either libraries have bad quality, are incomplete, or are simply not maintained anymore. Of all the ones we checked out, this one is the most promising. Unfortunately, it also doesn't seem to get a lot of love these days anymore tho. And while
web
support is generally there, non of the external controls or events work. Let's change that!To Reproduce
Steps to reproduce the behavior:
Do some research on all available YouTube embedding libraries + their activity (commits/open issues & replies) .. It's not great.
Expected behavior
As a first proposal, we'd like to suggest removing the dependency on
injectJavascript
. This, in return, will make this library work for both, native and web.To give you a first idea, here's a WIP commit: questmate@39074a8
This, combined with the following part changed/added to the
iframe.html
made things work fine in our limited testing so far.@LonelyCpp Any thoughts on this? Maybe there was a good reason for not simply relying on
postMessage
&onMessage
and instead working withinjectJavascript
? Also, do you have any interest in work resuming on the library, or would you instead recommend forking it or starting from scratch?Screenshots
N/A
Smartphone (please complete the following information):
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: