Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actually fetch all the objects from S3 #3

Open
LoneRifle opened this issue Feb 14, 2023 · 0 comments
Open

fix: actually fetch all the objects from S3 #3

LoneRifle opened this issue Feb 14, 2023 · 0 comments

Comments

@LoneRifle
Copy link
Owner

This driver currently fetches only the first 1000 blocks for a given file, the default behaviour for S3's listObjectsV2():

const { Contents: objects } = await this.s3.listObjectsV2({
Bucket: this.bucketName,
Prefix: `${prefix}/`,
})

This should be modified to fetch all objects

Originally posted by @LoneRifle in #1 (comment)

@LoneRifle LoneRifle changed the title TODO: actually fetch all the objects from S3 by changing the following block: fix: actually fetch all the objects from S3 by changing the following block: Feb 14, 2023
@LoneRifle LoneRifle changed the title fix: actually fetch all the objects from S3 by changing the following block: fix: actually fetch all the objects from S3 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant