-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page editor broken with latest version of Next? #54
Comments
I confirm the same issue happening for me. |
Even the starter pack still has the same issue. Which node version do you use? |
Just tested destack-react-starter and it works |
@sergor5 in destack-starter's
The bug dates from yesterday for me. |
I've found what causes the issue:
Shortly, for it to work now, install destack this way:
|
@ARMBouhali
|
Btw latest vesion So install it like: |
So for now, while installing |
@sergor5 Thank you for the quick feedback. |
after some adjustments in CSS,
Just add this CSS to file html,
body {
padding: 0;
margin: 0;
}
.gjs-layer-caret{
top: 4px !important;
transform: none !important;
}
.gjs-category-title, .gjs-layer-title, .gjs-block-category .gjs-title, .gjs-sm-sector .gjs-sm-title, .gjs-clm-tags .gjs-sm-title {
font-weight: lighter;
background-color: rgba(0,0,0,.1);
letter-spacing: 1px;
padding: 9px 10px 9px 20px;
border-bottom: 1px solid rgba(0,0,0,.25);
text-align: left;
position: relative;
cursor: pointer;
}
.gjs-sm-sector #gjs-sm-caret, .gjs-clm-tags #gjs-sm-caret {
padding-right: 5px;
font-size: 11px;
}
.gjs-toolbar-item {
padding: 5px 7px !important;
font-size: .8rem;
cursor: pointer;
width: 26px;
vertical-align: middle;
display: inline-block;
}
.gjs-sm-sector .gjs-sm-property .gjs-sm-layer #gjs-sm-preview, .gjs-clm-tags .gjs-sm-property .gjs-sm-layer #gjs-sm-preview, .gjs-sm-sector .gjs-sm-property .gjs-sm-layer #gjs-sm-preview-box, .gjs-clm-tags .gjs-sm-property .gjs-sm-layer #gjs-sm-preview-box {
border-radius: 2px;
}
.gjs-sm-sector .gjs-sm-property .gjs-sm-layer>#gjs-sm-preview-box, .gjs-clm-tags .gjs-sm-property .gjs-sm-layer>#gjs-sm-preview-box {
height: 15px;
position: absolute;
right: 27px;
top: 6px;
width: 15px;
}
.gjs-sm-sector .gjs-sm-property .gjs-sm-layer>#gjs-sm-preview-box #gjs-sm-preview, .gjs-clm-tags .gjs-sm-property .gjs-sm-layer>#gjs-sm-preview-box #gjs-sm-preview {
background-color: #fff;
height: 100%;
width: 100%;
background-size: cover !important;
}
.gjs-sm-sector .gjs-sm-property .gjs-sm-layer #gjs-sm-close-layer, .gjs-clm-tags .gjs-sm-property .gjs-sm-layer #gjs-sm-close-layer {
display: block;
font-size: 23px;
position: absolute;
cursor: pointer;
right: 5px;
top: 0;
opacity: .5;
filter: alpha(opacity=50);
}
.gjs-sm-sector .gjs-sm-property .gjs-sm-layer, .gjs-clm-tags .gjs-sm-property .gjs-sm-layer {
background-color: rgba(255,255,255,.055);
border-radius: 2px;
margin: 2px 0;
padding: 7px;
position: relative;
cursor: pointer;
}
.gjs-checker-bg, .gjs-field-colorp-c, .checker-bg, .gjs-sm-sector .gjs-sm-property .gjs-sm-layer>#gjs-sm-preview-box, .gjs-clm-tags .gjs-sm-property .gjs-sm-layer>#gjs-sm-preview-box {
background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAwAAAAMCAIAAADZF8uwAAAAGUlEQVQYV2M4gwH+YwCGIasIUwhT25BVBADtzYNYrHvv4gAAAABJRU5ErkJggg==");
}
.gjs-sm-sector .gjs-sm-stack #gjs-sm-add, .gjs-clm-tags .gjs-sm-stack #gjs-sm-add {
padding: 1px 6px !important;
width: revert;
height:revert;
font-size: 22px !important;
top: -22px !important;
}
.gjs-sm-sector .gjs-sm-field, .gjs-clm-tags .gjs-sm-field, .gjs-sm-sector .gjs-clm-select, .gjs-clm-tags .gjs-clm-select, .gjs-sm-sector .gjs-clm-field, .gjs-clm-tags .gjs-clm-field {
width: 100%;
position: relative;
display: block !important;
}
.gjs-sm-sector .gjs-sm-field input, .gjs-clm-tags .gjs-sm-field input, .gjs-sm-sector .gjs-clm-select input, .gjs-clm-tags .gjs-clm-select input, .gjs-sm-sector .gjs-clm-field input, .gjs-clm-tags .gjs-clm-field input, .gjs-sm-sector .gjs-sm-field select, .gjs-clm-tags .gjs-sm-field select, .gjs-sm-sector .gjs-clm-select select, .gjs-clm-tags .gjs-clm-select select, .gjs-sm-sector .gjs-clm-field select, .gjs-clm-tags .gjs-clm-field select {
color: #6366f1 !important;
background-color: #dddada !important;
}
.gjs-sm-layer.gjs-sm-active {
background-color: rgb(72 72 72 / 12%) !important;
} |
I finally get to reproduce the issue locally by deleting my Some things I found looking into this: 1. The issue is because of Grapesjs CSS importsThe issue is because grapes is not resolved as a dependency nor do grapesjs CSS imports. The line that creates this issue is the following: On the contrary, if the project has or had 2. Is not affected. by Destack, react or next.js versionI tested it with different version of destack (including 0.12.0 and 1.0.3) and different versions of react (17 and 18) and nextjs (12 and 13) and the issue persists. If someone has a different experience might be good to delete |
The suggested solution for now is to install grapes v0.17 manually: PS: Indeed [email protected] breaks some CSS (thanks @sergor5 for the investigation). It has to do with a few CSS overrides Destack has. |
As a side note:The reason this happens is not known yet and I'm very curious to learn what it is as I didn't changed anything with my setup and from my understanding nor did most people. One possibility is that that is caused by [email protected] which was had releases recently. It shouldn't changed anything as it's a patch version but these things happen. |
yea i got problem when try run
|
What's the setup you are facing the issue on? Node.js / React / Next.js versions? Have you tried #54 (comment) solution? |
i'm not create next/reach app just fork destack-starter Call Stack and when i drag component from library, they just become image not properly component |
On my machine it's working after I want to look into it but I need a way to reproduce the issue. |
Followed install instructions except used 'npx create-next-app@latest'.
Dragging a component from the picker to a page places an image of the component instead of the component.
Please advise. Thx.
The text was updated successfully, but these errors were encountered: