Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] support standard openId-connect for authentication #823

Closed
maxisam opened this issue Jul 29, 2022 · 25 comments
Closed

[FEATURE_REQUEST] support standard openId-connect for authentication #823

maxisam opened this issue Jul 29, 2022 · 25 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 📌 Keep Open [ISSUE][PR] Prevent auto-closing

Comments

@maxisam
Copy link

maxisam commented Jul 29, 2022

Is your feature request related to a problem? If so, please describe.

Spining up a keycloak is really heavy. Dex is much light weight for most of use cases.

And OIDC/oAuth2 is a well known protocol. With this, you can use keycloak/AzureAd/Google/...

From architecture stand point, it makes more sense to support it.

Describe the solution you'd like

I think we can use a library like https://github.com/authts/oidc-client-ts to do this.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

Maybe

OpenID Connect (OIDC) and OAuth2 protocol support for browser-based JavaScript applications - GitHub - authts/oidc-client-ts: OpenID Connect (OIDC) and OAuth2 protocol support for browser-based Jav...
@maxisam maxisam added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Jul 29, 2022
@liss-bot
Copy link
Collaborator

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Aug 29, 2022
@ToshY
Copy link

ToshY commented Aug 29, 2022

Definitely still relevant 😄

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Aug 29, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Sep 1, 2022

/keep-open

@Lissy93 Lissy93 added the 📌 Keep Open [ISSUE][PR] Prevent auto-closing label Sep 1, 2022
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Sep 1, 2022
@schewara
Copy link

I totally agree with @maxisam

Switching from Keycloak to a general oidc/oauth2 solution would allow out of the box integration of most Identity Providers out there, like Authentik, Authelia, ORY Hydra, Zitadel, WSO2, Okta, Auth0, many many more and of course Keycloak as well.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Sep 19, 2022
@Lissy93 Lissy93 mentioned this issue Sep 25, 2022
4 tasks
@hooray4me
Copy link

Agree!

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Sep 25, 2022
@obsidiangroup
Copy link

This is a feature that I would love to see implemented. @Lissy93 has mentioned in other issues that integrating Authentik was not on the road-map, which is perfectly fine. You are correct, there are so many different solutions out there. But supporting a standard like OIDC or SAML would let the software not be dependent on any specific IDP. Unless you are using Keycloak for complete user management, then supporting OIDC/SAML should not be a major problem. Granted, I have not looked at any code.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Oct 2, 2022
@FieldofClay
Copy link

+1 for this feature.
Also, maybe header authentication could be implemented as a lower effort, similar value option? Have Dashy grab user/group info from headers, instead of internal authentication, then use the same configuration options to show/hide sections etc.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Nov 1, 2022
@sargonas
Copy link

as an authelia user, a +1 from me to, to simply these types of integrations via OIDC!

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Jan 16, 2023
@joshp23
Copy link

joshp23 commented Feb 5, 2023

I moved from Keycloak to Authentik and would very much appreciate a generic OIDC implementation.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Feb 5, 2023
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 7, 2023
@Ryamonster10
Copy link

Another +1 for OIDC connectivity. I use ADFS for all my services and it would be much easier to tie this directly into ADFS than what I am doing now which is this to key-cloak to ADFS.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 27, 2023
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label May 10, 2023
@hdlineage
Copy link

+1 for this. OIDC support would make Dashy standout from the rest.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Jun 5, 2023
@appiekap653
Copy link

+1 for this. Generic standards like openID-connect or SAML or even header-authentication will make it usable with almost every idp+authentication platform you can imagine. No need to create code for every provider there is. only need to code it once with the support for those generic standards and you are done for all those providers.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Aug 5, 2023
@AutoGitr
Copy link

+1 once more. This would be an excellent improvement to Dashy and truly make it a modern dashboard.

@Itay1787
Copy link

+1 As an authentik user, is there currently a way to connect authentik?

@ToshY
Copy link

ToshY commented Oct 21, 2023

+1 As an authentik user, is there currently a way to connect authentik?

Not with Dashy directly, as there is currently no generic OIDC implementation.

You could however create an OAuth2 provider in Authentik and use oauth2-proxy instead.

@Lockszmith-GH
Copy link

You could however create an OAuth2 provider in Authentik and use oauth2-proxy instead.

You'll need that with Authy maybe, but authentik has it's own proxy implementation, no need for another part.

The reason people want this here, is to be able to use SSO for different users, something the proxy doesn't solve. The proxy only provides an open/close gate.

@TheRealGramdalf
Copy link

Is this planned as part of v3? OIDC would be the cherry on top for this already amazing program.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 1, 2024
@vgwizardx
Copy link

vgwizardx commented Mar 1, 2024

So if you are using Cloudflare Zero Trust Tunnels you can add SSO to Dashy and other selfhosted apps using this method. https://blog.wains.be/2023/2023-01-07-cloudflare-zero-trust-authentik/. I found this really easy to setup especially if you are already using tunnels.

My notes about open source stuff.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 1, 2024
@Ryamonster10
Copy link

Ryamonster10 commented Mar 1, 2024 via email

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 2, 2024
@vgwizardx
Copy link

vgwizardx commented Mar 2, 2024

That’s great, but it doesn’t provide per user permissions, just page protection, and you still have to deal with double authentication which means two passwords to keep up and you can’t only have some thing assigned to some people.

On Fri, Mar 1, 2024 at 15:27 Joseph Washington Jr @.> wrote: So if you are using Cloudflare Zero Trust Tunnels you can add SSO to Dashy and other selfhosted apps using this method. https://blog.wains.be/2023/2023-01-07-cloudflare-zero-trust-authentik/ https://blog.wains.be/2023/2023-01-07-cloudflare-zero-trust-authentik/. I found this really easy to setup especially if you are already using tunnels. * Single Sign On with Authentik for your services behind Cloudflare zero trust https://blog.wains.be/2023/2023-01-07-cloudflare-zero-trust-authentik/ * My notes about open source stuff. — Reply to this email directly, view it on GitHub <#823 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKXPDC42W4CIKHTIJA7ZU33YWDQDPAVCNFSM55BSDANKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJXGM4DMNZYGIYQ . You are receiving this because you commented.Message ID: @.>

No, it's not perfect, but I just set up one admin and a guest account. It would be nice to have everything. But hey, this is good enough for me for now.

My notes about open source stuff.
GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 420 million projects.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 2, 2024
@vgwizardx
Copy link

vgwizardx commented Mar 2, 2024

So I was looking at Audiobookshelf and noticed they do have OIDC implementation. I might fork this and use their implementation as a guide to learn how to set it up on Dashy. I will update if I decided to give it a shot. Anyone else want to look into it. https://github.com/advplyr/audiobookshelf/blob/master/client/pages/config/authentication.vue

Self-hosted audiobook and podcast server. Contribute to advplyr/audiobookshelf development by creating an account on GitHub.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Mar 3, 2024
@rxunique
Copy link

+1 I just went through the journey but hit a wall with keycloak group and role doesn't work in dashy as expected.

Wish there's authentik integration with per user permission via OIDC

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Apr 26, 2024
@twsouthwick
Copy link
Contributor

FYI - I got an implementation of it in #1573 that I'd appreciate any thoughts on :)

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels May 10, 2024
@Lissy93
Copy link
Owner

Lissy93 commented May 13, 2024

Thanks so much @twsouthwick
Looks awesome, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 📌 Keep Open [ISSUE][PR] Prevent auto-closing
Projects
None yet
Development

No branches or pull requests