refactor(match2): remove match.vod in favor of match.links.vod #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Oct 22, 2024
| @@ -417,8 +417,8 @@ end | |||
| ---@return {index: number, link: string}[] | |||
| function MatchTable:vodsFromRecord(record) | |||
| local vods = {} | |||
| if String.nilIfEmpty(record.vod) then | |||
| vods = {{index = 0, link = record.vod}} | |||
| if String.nilIfEmpty(record.links.vod) then | |||
There was a problem hiding this comment.
links is not retrieved, you need to adjust the query param in the query calls too (lines 290-291)
hjpalpha
reviewed
Oct 22, 2024
| @@ -311,7 +311,7 @@ function Details:countdown(matchPageIcon) | |||
|
|
|||
| local gameVods = Array.map(Array.map(match.match2games, Operator.property('vod')), makeVod) | |||
|
|
|||
| countdownDisplay:node(makeVod(match.vod)) | |||
| countdownDisplay:node(makeVod(match.links.vod)) | |||
There was a problem hiding this comment.
need to adjust DEFAULT_QUERY_COLUMNS too
and check if there are places overwriting that default somewhere
and also infobox player on sc2
|
should probably also update the comment in Module:Lpdb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #4940
Waiting for some standardization from #4939 and backwards compatibility setup in #4822 before this PR can be completed.
https://liquipedia.net/starcraft2/Module:HeadToHead needs to be updated after golive
How did you test this change?