Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysfs-interface-test #527

Closed
wants to merge 1 commit into from
Closed

Add sysfs-interface-test #527

wants to merge 1 commit into from

Conversation

vishalbhoj
Copy link
Contributor

No description provided.

Signed-off-by: Vishal Bhoj <[email protected]>
@mwasilew
Copy link
Contributor

@vishalbhoj nice job!
I think it might be a good idea to allow users to select which tests to run on their platform. For example the test will always fail on platform without BT and not all boards have BT. Also not all kernels enable BT.

@@ -0,0 +1,22 @@
metadata:
format: Lava-Test Test Definition 1.0
name: module-tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change test
name: sysfs-interface-test

- openembedded
scope:
- functional
devices:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devices:
Please add known good LAVA connected devices which supports any of these test cases.

Copy link
Collaborator

@nareshkamboju nareshkamboju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishalbhoj Thanks taking your time in writing a new test cases.
I have a few minor comments.

echo "No displays connected."
fi
else
echo "drm-sysfs-test fail" >> $RESULT_FILE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any scope to skip test cases ?
When Kconfigs not enabled / device do not have these peripherals / interfaces we could skip those tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nareshkamboju for the feedback. I'll close the PR for now. I'll open the PR again later once I have improved the implementation.

@vishalbhoj
Copy link
Contributor Author

@mwasilew Thank you for the feedback. I was just experimenting on the testcase. I'll be closing the PR for now. I'll create a new one with once I have improved the testcase.

@vishalbhoj vishalbhoj closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants