-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sysfs-interface-test #527
Conversation
cea28dd
to
c0dbe17
Compare
Signed-off-by: Vishal Bhoj <[email protected]>
c0dbe17
to
6eaf6f1
Compare
@vishalbhoj nice job! |
@@ -0,0 +1,22 @@ | |||
metadata: | |||
format: Lava-Test Test Definition 1.0 | |||
name: module-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change test
name: sysfs-interface-test
- openembedded | ||
scope: | ||
- functional | ||
devices: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devices:
Please add known good LAVA connected devices which supports any of these test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishalbhoj Thanks taking your time in writing a new test cases.
I have a few minor comments.
echo "No displays connected." | ||
fi | ||
else | ||
echo "drm-sysfs-test fail" >> $RESULT_FILE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any scope to skip test cases ?
When Kconfigs not enabled / device do not have these peripherals / interfaces we could skip those tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nareshkamboju for the feedback. I'll close the PR for now. I'll open the PR again later once I have improved the implementation.
@mwasilew Thank you for the feedback. I was just experimenting on the testcase. I'll be closing the PR for now. I'll create a new one with once I have improved the testcase. |
No description provided.