-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ota apps #477
Ota apps #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@@ -1,4 +1,4 @@ | |||
#!/bin/bash -e | |||
|
|||
echo "${MESSAGE}" > /var/sota/ota.signal | |||
echo "${MESSAGE}" >> /var/sota/ota.signal | |||
echo "${RESULT}" > /var/sota/ota.result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be '>>' to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RESULT is not used in the scripts, so it doesn't really matter.
#!/bin/bash -e | ||
|
||
echo "${MESSAGE}" >> /var/sota/ota.signal | ||
echo "${RESULT}" >> /var/sota/ota.result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be '>>' or '>' ?
This file is the same across all ota-rollback, ota-update and ota-apps.
Can it be the same file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can, and it would be preferred. Any ideas where to move this file? My original idea was that each test directory is self contained. Sharing files would break it, but in this instance it makes sense. Some suggestions are more than welcome.
reboot_command = "/bin/true" | ||
[pacman] | ||
callback_program = "/var/sota/aklite-callback.sh" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this file be the same all across the different ota-rollback, ota-update and ota-apps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as with aklite-callback.sh. This is a shared file, but I don't know how to use it in all test dirs.
Sometimes signal duration is shorter than the wait time in the script. This patch ensures all signals are registered. Since the tests are looking for 1st occurance of the signal, there should not be issues with signals happening more than once. Signed-off-by: Milosz Wasilewski <[email protected]>
Add a test for OTA update of docker apps. This is slightly different to OS OTA update as it usually doesn't require a reboot and can be tested with a single LAVA test acition. Signed-off-by: Milosz Wasilewski <[email protected]>
Fix OTA signal handling and add a test for OTA update of docker apps.