Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

If a suite is not given, / is shown as the suite name. #68

Open
jscook2345 opened this issue Sep 25, 2020 · 2 comments
Open

If a suite is not given, / is shown as the suite name. #68

jscook2345 opened this issue Sep 25, 2020 · 2 comments

Comments

@jscook2345
Copy link
Contributor

example:

https://qa-reports.linaro.org/~justin.cook/mirror-linux-next-master-sanity/build/next-20200924/?results_layout=table&failures_only=false#!#test-results

Not sure if this is a squad or squad-client issue. So let's start here!

I ran the following command:

#!/usr/bin/env bash

set -x

squad-client \
  --squad-host 'https://qa-reports.linaro.org' \
  --squad-token '<REMOVED>' \
  submit \
  --group '~justin.cook' \
  --project 'mirror-linux-next-master-sanity' \
  --build 'next-20200924' \
  --environment 'x86' \
  --result-name 'build-x86-gcc' \
  --result-value 'pass'

If you go to the above example URL, you will see the suite name for this test result is / (forward slash). This probably is incorrect.

I'm not sure if:
squad-client should reject this, forcing you to define a suite
or
squad should reject squad-clients request because no suite is given
or
this is perfectly valid
or
something else.

What do you think?

@jscook2345
Copy link
Contributor Author

jscook2345 commented Sep 25, 2020

I also found that this causes some other problems (maybe?). Here is a URL for the test history for example:

https://qa-reports.linaro.org/~justin.cook/mirror-linux-next-master-sanity/build/next-20200924/testrun/3234193/suite/$/test/build-x86-gcc/history/

Note the $ in there for the suite name.

@mwasilew
Copy link
Contributor

With the current implementation missing (or empty) suite name is valid. The $ in URL is the UI feature. Maybe we should not allow empty suite at all? If this causes problems disabling empty suite is the easiest solution and should be done in squad (not client).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants