You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
compare_builds is expected to return a dict, however when one of the builds is not finished, you get the following:
['Cannot report regressions/fixes on a non-finished builds']
I'm not sure this is correct behavior. Perhaps it should return something else (none?) and squad-client can throw an exception letting me know that it cannot work on unfinished builds
The text was updated successfully, but these errors were encountered:
@jscook2345 but how to show the error to those looking at the UI? Maybe we can add something to client to test if build.finished==true before calling executing the actual compare, then throwing the error if not.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
compare_builds
is expected to return adict
, however when one of the builds is not finished, you get the following:['Cannot report regressions/fixes on a non-finished builds']
I'm not sure this is correct behavior. Perhaps it should return something else (none?) and
squad-client
can throw an exception letting me know that it cannot work on unfinished buildsThe text was updated successfully, but these errors were encountered: