Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

compare_builds returns message instead of variable for an unfinished build #108

Open
jscook2345 opened this issue Jan 14, 2021 · 1 comment

Comments

@jscook2345
Copy link
Contributor

compare_builds is expected to return a dict, however when one of the builds is not finished, you get the following:

['Cannot report regressions/fixes on a non-finished builds']

I'm not sure this is correct behavior. Perhaps it should return something else (none?) and squad-client can throw an exception letting me know that it cannot work on unfinished builds

@amrohassaan
Copy link
Contributor

@jscook2345 but how to show the error to those looking at the UI? Maybe we can add something to client to test if build.finished==true before calling executing the actual compare, then throwing the error if not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants