Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support arm64 architecture #2

Open
longquan7 opened this issue Oct 10, 2017 · 21 comments
Open

support arm64 architecture #2

longquan7 opened this issue Oct 10, 2017 · 21 comments

Comments

@longquan7
Copy link

I was build this image on arm64 architecture and successed ,So I want to know can we add it to the https://hub.docker.com/u/arm64v8/ ?

@gfinocchiaro
Copy link
Contributor

As far as I know, to make it available from https://hub.docker.com/u/arm64v8/ it is required to update the official definition file, but we'll do that in the next few weeks when Lightstreamer 7 will be officially released.

@lag-linaro
Copy link

@gfinocchiaro we have managed to build and run Lightstreamer on ARM64v8 with no issues.

Would it be okay to enable this project so that it's docker pullable on our systems please?

If you need help, I would be happy to provide a Pull Request for you.

@gfinocchiaro
Copy link
Contributor

Hi,

do you have a link from which I can view the definition file?

@lag-linaro
Copy link

THIS is the file that needs changing.

Again, I'm happy to do it for you if you'd support it.

@gfinocchiaro
Copy link
Contributor

Ok, thanks.
Does the Dockerfile needs any specific update?

@lag-linaro
Copy link

The current Dockerfile 'just worked' on our ARM64v8 platform.

No other changes are required to support it.

@gfinocchiaro
Copy link
Contributor

May I ask you for which kind of devices are you planning to run the Lightstreamer Docker image?

@lag-linaro
Copy link

I am currently testing it on an Enterprise level (64-cores, 256GB RAM, etc) platform.

@gfinocchiaro
Copy link
Contributor

Ok, feel free to make a PR.

@lag-linaro
Copy link

Okay, all done. Please feel free to review and/or provide your Ack.

docker-library/official-images#4570

@longquan7
Copy link
Author

@lag-linaro That's great, if you make a PR please let me know

@gfinocchiaro
Copy link
Contributor

Probably, you should have opened a PR for our fork. After that, I'll accept and then "forward" the PR for the master project. Sorry for not being too clear.

Please, close the PR and open a new one for our fork project.
Thanls

@lag-linaro
Copy link

Ah yes, I can do that. Would you mind rebasing it though please?

"This branch is 2 commits ahead, 157 commits behind docker-library:master."

Looks like you still have 2 commits which are yet to be merged too?

@gfinocchiaro
Copy link
Contributor

Oh yes, you're right!

Please for this project instead, which is currently synched.

@lag-linaro
Copy link

It doesn't appear to be working screenshot

@lag-linaro
Copy link

Would you be kind enough to explain why the patches need to be routed by your tree please?

It's more common to submit directly to the upstream repo.

@gfinocchiaro
Copy link
Contributor

Not very expert actually. Anyway, I'll do the required change from my project. Please remove your previous PR and, once done, I'll open the same PR.

@lag-linaro
Copy link

lag-linaro commented Jul 12, 2018

So the easiest thing for you to do is:

git remote add lag-linaro https://github.com/lag-linaro/official-images.git
git fetch lag-linaro
git cherry-pick lag-linaro/lightstreamer-enable-arm64v8

Then push the result to your own Official Images repos and send the PR from there.

@gfinocchiaro
Copy link
Contributor

Thanks!

docker-library/official-images#4576

Would you mind closing the previuos one? (if possible)

@lag-linaro
Copy link

Closed. Thanks.

@gfinocchiaro
Copy link
Contributor

Hi,

would you mind privately writing to me to show us your interest in Lightstreamer technology?

Thanks and Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants