Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on_validation_model_train/eval to Callback API as well #20441

Open
yundai424 opened this issue Nov 22, 2024 · 0 comments
Open

Add on_validation_model_train/eval to Callback API as well #20441

yundai424 opened this issue Nov 22, 2024 · 0 comments
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers

Comments

@yundai424
Copy link

yundai424 commented Nov 22, 2024

Description & Motivation

Today on_validation_model_train/eval (similar to on_test_xxx) is only available in LightningModule. It would be helpful to open up this interface to callback as well especially as callbacks are much more pluggable. This will be very helpful for implementing ScheduleFree optimizers which has been proved to be very convergence efficient: https://github.com/facebookresearch/schedule_free/tree/main/schedulefree

I'd be happy to draft a PR if this idea is approved.

Pitch

Add on_validation_model_train/eval (and those for test) to callback API

Alternatives

No response

Additional context

No response

cc @Borda

@yundai424 yundai424 added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers
Projects
None yet
Development

No branches or pull requests

1 participant