Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaglibSharp 2.2.0 has been released #10

Open
decriptor opened this issue Jul 22, 2019 · 8 comments
Open

TaglibSharp 2.2.0 has been released #10

decriptor opened this issue Jul 22, 2019 · 8 comments

Comments

@decriptor
Copy link

If you all are willing it'd be nice to close this repo and just work on the upstream version. I believe I've merged all of the changes at this point and published a new nuget package.

https://github.com/mono/taglib-sharp/releases/tag/TaglibSharp-2.2.0

@Qstick
Copy link

Qstick commented Aug 15, 2019

@decriptor I don’t think we mind blitzing the package, but the main reason we started was due to long periods of unresponsiveness on the main repo. This was causing issue with our user base and implementation that we needed to solve. Do you feel confident that when issues come up that they can/will be addressed quickly?

@decriptor
Copy link
Author

@Qstick Funny enough you caught me on vacation. I think now that things are a bit more cleaned up and simplified I'm hoping to have more regular responsive release. If you need a PR merged and a release done quickly I think I'm better able to do that now.

@ta264
Copy link

ta264 commented Sep 18, 2020

@decriptor If I PR #12 upstream any chance of a merge + release in the next few days? Turns out lidarr is corrupting OPUS files on tag write 😬

@decriptor
Copy link
Author

@ta264 Let me see if I can knock something out this weekend.

@ta264
Copy link

ta264 commented Sep 18, 2020

Thanks! You can hit me up on the lidarr discord if you want to discuss anything

@decriptor
Copy link
Author

@ta264 Would you be ok creating a PR against mono/taglib-sharp and create a test? If not, I'll create a PR and try to put together a unit test. Let me know.

@ta264
Copy link

ta264 commented Sep 21, 2020

I was testing locally by calling out to opusinfo to verify integrity. Would that be acceptable or do you want it to be totally self contained?

@decriptor
Copy link
Author

@ta264 It is so that CI can run the test and make sure we don't regress when new PRs come in. Essentially making sure this bug isn't regressed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants